Skip to content

[PM-34891] Use star end icons in buttons#20232

Merged
voommen-livefront merged 19 commits intomainfrom
dirt/pm-34891/use-star-end-icons-in-buttons
May 6, 2026
Merged

[PM-34891] Use star end icons in buttons#20232
voommen-livefront merged 19 commits intomainfrom
dirt/pm-34891/use-star-end-icons-in-buttons

Conversation

@voommen-livefront
Copy link
Copy Markdown
Collaborator

@voommen-livefront voommen-livefront commented Apr 17, 2026 •
edited
Loading

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-34891

📔 Objective

Avoid using in buttons.
Use the startIcon and endIcon attributes instead.
This PR follows the PR for PM-34890
#20181

📸 Screenshots

Screen shots attached in the story to assist the QA team

@voommen-livefront voommen-livefront requested review from a team as code owners April 17, 2026 14:08
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 17, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.17%. Comparing base (e57b460) to head (46ad702).
⚠️ Report is 8 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #20232   +/-   ##
=======================================
  Coverage   47.17%   47.17%           
=======================================
  Files        3948     3948           
  Lines      119883   119883           
  Branches    18398    18398           
=======================================
+ Hits        56554    56556    +2     
+ Misses      59050    59048    -2     
  Partials     4279     4279

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 17, 2026 •
edited
Loading

Logo
Checkmarx One – Scan Summary & Details – b4de42c2-9b7f-4046-bb73-dc1081c1f9f1

Great job! No new security vulnerabilities introduced in this pull request

@voommen-livefront voommen-livefront marked this pull request as draft April 20, 2026 15:35
@JaredScar
Copy link
Copy Markdown
Contributor

JaredScar commented Apr 28, 2026

Is this ready for review? PR says it's a draft?

@voommen-livefront
Copy link
Copy Markdown
Collaborator Author

voommen-livefront commented Apr 28, 2026

@JaredScar Thanks for noticing - but this PR is not yet ready for review. I have a PR #20181 that should be merged before this.

@voommen-livefront voommen-livefront marked this pull request as ready for review April 30, 2026 21:02
@voommen-livefront
Copy link
Copy Markdown
Collaborator Author

voommen-livefront commented Apr 30, 2026

@JaredScar - finally this PR is ready for review and it is much smaller than before. just a few changes required as CL-1109 and PR #20232 fixed most of the issues

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 30, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

JaredScar
JaredScar approved these changes May 1, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@JaredScar JaredScar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@voommen-livefront voommen-livefront merged commit a903848 into main May 6, 2026
66 checks passed
@voommen-livefront voommen-livefront deleted the dirt/pm-34891/use-star-end-icons-in-buttons branch May 6, 2026 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JaredScar JaredScar JaredScar approved these changes

@Banrion Banrion Banrion approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@voommen-livefront @JaredScar @Banrion